CVE-2024-50082 blk-rq-qos: fix crash on rq_qos_wait vs. rq_qos_wake_function race
- Published
- Updated
- Exploit status
- No public exploit known
- CISA SSVC
- No known exploitation · automatable: no · technical impact: total
- Technology
- Linux KernelUbuntuDebian
Description
In the Linux kernel, the following vulnerability has been resolved:
blk-rq-qos: fix crash on rq_qos_wait vs. rq_qos_wake_function race
We're seeing crashes from rq_qos_wake_function that look like this:
BUG: unable to handle page fault for address: ffffafe180a40084
#PF: supervisor write access in kernel mode
#PF: error_code(0x0002) - not-present page
PGD 100000067 P4D 100000067 PUD 10027c067 PMD 10115d067 PTE 0
Oops: Oops: 0002 [#1] PREEMPT SMP PTI
CPU: 17 UID: 0 PID: 0 Comm: swapper/17 Not tainted 6.12.0-rc3-00013-geca631b8fe80 #11
Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.16.0-0-gd239552ce722-prebuilt.qemu.org 04/01/2014
RIP: 0010:_raw_spin_lock_irqsave+0x1d/0x40
Code: 90 90 90 90 90 90 90 90 90 90 90 90 90 f3 0f 1e fa 0f 1f 44 00 00 41 54 9c 41 5c fa 65 ff 05 62 97 30 4c 31 c0 ba 01 00 00 00 <f0> 0f b1 17 75 0a 4c 89 e0 41 5c c3 cc cc cc cc 89 c6 e8 2c 0b 00
RSP: 0018:ffffafe180580ca0 EFLAGS: 00010046
RAX: 0000000000000000 RBX: ffffafe180a3f7a8 RCX: 0000000000000011
RDX: 0000000000000001 RSI: 0000000000000003 RDI: ffffafe180a40084
RBP: 0000000000000000 R08: 00000000001e7240 R09: 0000000000000011
R10: 0000000000000028 R11: 0000000000000888 R12: 0000000000000002
R13: ffffafe180a40084 R14: 0000000000000000 R15: 0000000000000003
FS: 0000000000000000(0000) GS:ffff9aaf1f280000(0000) knlGS:0000000000000000
CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
CR2: ffffafe180a40084 CR3: 000000010e428002 CR4: 0000000000770ef0
DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000
DR3: 0000000000000000 DR6: 00000000fffe0ff0 DR7: 0000000000000400
PKRU: 55555554
Call Trace:
<IRQ>
try_to_wake_up+0x5a/0x6a0
rq_qos_wake_function+0x71/0x80
__wake_up_common+0x75/0xa0
__wake_up+0x36/0x60
scale_up.part.0+0x50/0x110
wb_timer_fn+0x227/0x450
...
So rq_qos_wake_function() calls wake_up_process(data->task), which calls
try_to_wake_up(), which faults in raw_spin_lock_irqsave(&p->pi_lock).
p comes from data->task, and data comes from the waitqueue entry, which
is stored on the waiter's stack in rq_qos_wait(). Analyzing the core
dump with drgn, I found that the waiter had already woken up and moved
on to a completely unrelated code path, clobbering what was previously
data->task. Meanwhile, the waker was passing the clobbered garbage in
data->task to wake_up_process(), leading to the crash.
What's happening is that in between rq_qos_wake_function() deleting the
waitqueue entry and calling wake_up_process(), rq_qos_wait() is finding
that it already got a token and returning. The race looks like this:
rq_qos_wait() rq_qos_wake_function()
prepare_to_wait_exclusive()
data->got_token = true;
list_del_init(&curr->entry);
if (data.got_token)
break;
finish_wait(&rqw->wait, &data.wq);
^- returns immediately because
list_empty_careful(&wq_entry->entry)
is true
... return, go do something else ...
wake_up_process(data->task)
(NO LONGER VALID!)-^
Normally, finish_wait() is supposed to synchronize against the waker.
But, as noted above, it is returning immediately because the waitqueue
entry has already been removed from the waitqueue.
The bug is that rq_qos_wake_function() is accessing the waitqueue entry
AFTER deleting it. Note that autoremove_wake_function() wakes the waiter
and THEN deletes the waitqueue entry, which is the proper order.
Fix it by swapping the order. We also need to use
list_del_init_careful() to match the list_empty_careful() in
finish_wait().
Upgrade path
10 packages: 10 fixed.
| Package | Affected | Fixed in | Status |
|---|---|---|---|
| debian/linux(Debian 12) | < 6.1.115-1; = 6.1.27-1; = 6.1.37-1; = 6.1.38-1 +27 more | 6.1.115-1 | Fixed |
| debian/linux(Debian 13) | < 6.11.5-1 | 6.11.5-1 | Fixed |
| debian/linux(Debian 14) | < 6.11.5-1 | 6.11.5-1 | Fixed |
| Linux kernel | < 5.4.285; < 5.10.228; < 5.15.169; < 6.1.114 +19 more | 3bc6d0f8b70a9101456cf02ab99acb75254e1852, 4c5b123ab289767afe940389dbb963c5c05e594e, 04f283fc16c8d5db641b6bffd2d8310aa7eccebc, 5.4.285, 5.10.228, 5.15.169, 6.1.114, 6.6.58, 6.11.5, 6.12, 455a469758e57a6fe070e3e342db12e4a629e0eb, b5e900a3612b69423a0e1b0ab67841a1fb4af80f, d04b72c9ef2b0689bfc1057d21c4aeed087c329f, e972b08b91ef48488bae9789f03cfedb148667fb | Fixed |
| Microsoft cbl mariner | < 5.15.173.1-1 | 5.15.173.1-1 | Fixed |
| ubuntu/linux(Ubuntu 22.04) | < 5.15.0-133.144 | 5.15.0-133.144 | Fixed |
| ubuntu/linux(Ubuntu 24.04) | < 6.8.0-56.58 | 6.8.0-56.58 | Fixed |
| ubuntu/linux-kvm(Ubuntu 22.04) | < 5.15.0-1076.81 | 5.15.0-1076.81 | Fixed |
| ubuntu/linux-raspi(Ubuntu 22.04) | < 5.15.0-1072.75 | 5.15.0-1072.75 | Fixed |
| ubuntu/linux-raspi(Ubuntu 24.04) | < 6.8.0-1028.32 | 6.8.0-1028.32 | Fixed |
Affected products
| Product | Affected versions | Fixed in |
|---|---|---|
| Microsoft cbl mariner | < 5.15.173.1-1 | 5.15.173.1-1 |
| debian/linux(Debian:12) | < 6.1.115-1 | 6.1.115-1 |
| debian/linux(Debian:12) | = 6.1.106-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.106-2 | No fix listed |
| debian/linux(Debian:12) | = 6.1.106-3 | No fix listed |
| debian/linux(Debian:12) | = 6.1.112-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.27-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.37-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.38-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.38-2 | No fix listed |
| debian/linux(Debian:12) | = 6.1.38-2~bpo11+1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.38-3 | No fix listed |
| debian/linux(Debian:12) | = 6.1.38-4 | No fix listed |
| debian/linux(Debian:12) | = 6.1.38-4~bpo11+1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.52-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.55-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.55-1~bpo11+1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.64-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.66-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.67-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.69-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.69-1~bpo11+1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.76-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.76-1~bpo11+1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.82-1 | No fix listed |
Show 37 more
| Product | Affected versions | Fixed in |
|---|---|---|
| debian/linux(Debian:12) | = 6.1.85-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.90-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.90-1~bpo11+1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.94-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.94-1~bpo11+1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.98-1 | No fix listed |
| debian/linux(Debian:12) | = 6.1.99-1 | No fix listed |
| debian/linux(Debian:13) | < 6.11.5-1 | 6.11.5-1 |
| debian/linux(Debian:14) | < 6.11.5-1 | 6.11.5-1 |
| ubuntu/linux(Ubuntu:22.04) | < 5.15.0-133.144 | 5.15.0-133.144 |
| ubuntu/linux-kvm(Ubuntu:22.04) | < 5.15.0-1076.81 | 5.15.0-1076.81 |
| ubuntu/linux-raspi(Ubuntu:22.04) | < 5.15.0-1072.75 | 5.15.0-1072.75 |
| Linux kernel | >= 38cfb5a45ee013bfab5d1ae4c4738815e744b440, < d04b72c9ef2b0689bfc1057d21c4aeed087c329f | d04b72c9ef2b0689bfc1057d21c4aeed087c329f |
| Linux kernel | >= 38cfb5a45ee013bfab5d1ae4c4738815e744b440, < 3bc6d0f8b70a9101456cf02ab99acb75254e1852 | 3bc6d0f8b70a9101456cf02ab99acb75254e1852 |
| Linux kernel | >= 38cfb5a45ee013bfab5d1ae4c4738815e744b440, < 455a469758e57a6fe070e3e342db12e4a629e0eb | 455a469758e57a6fe070e3e342db12e4a629e0eb |
| Linux kernel | >= 38cfb5a45ee013bfab5d1ae4c4738815e744b440, < b5e900a3612b69423a0e1b0ab67841a1fb4af80f | b5e900a3612b69423a0e1b0ab67841a1fb4af80f |
| Linux kernel | >= 38cfb5a45ee013bfab5d1ae4c4738815e744b440, < 4c5b123ab289767afe940389dbb963c5c05e594e | 4c5b123ab289767afe940389dbb963c5c05e594e |
| Linux kernel | >= 38cfb5a45ee013bfab5d1ae4c4738815e744b440, < 04f283fc16c8d5db641b6bffd2d8310aa7eccebc | 04f283fc16c8d5db641b6bffd2d8310aa7eccebc |
| Linux kernel | >= 38cfb5a45ee013bfab5d1ae4c4738815e744b440, < e972b08b91ef48488bae9789f03cfedb148667fb | e972b08b91ef48488bae9789f03cfedb148667fb |
| Linux kernel | = 4.19 | No fix listed |
| Linux kernel | < 5.4.285 | 5.4.285 |
| Linux kernel | < 5.10.228 | 5.10.228 |
| Linux kernel | < 5.15.169 | 5.15.169 |
| Linux kernel | < 6.1.114 | 6.1.114 |
| Linux kernel | < 6.6.58 | 6.6.58 |
| Linux kernel | < 6.11.5 | 6.11.5 |
| Linux kernel | < 6.12 | 6.12 |
| ubuntu/linux(Ubuntu:24.04) | < 6.8.0-56.58 | 6.8.0-56.58 |
| ubuntu/linux-raspi(Ubuntu:24.04) | < 6.8.0-1028.32 | 6.8.0-1028.32 |
| Linux kernel | >= 4.19, < 5.10.228 | 5.10.228 |
| Linux kernel | >= 5.11, < 5.15.169 | 5.15.169 |
| Linux kernel | >= 5.16, < 6.1.114 | 6.1.114 |
| Linux kernel | >= 6.2, < 6.6.58 | 6.6.58 |
| Linux kernel | >= 6.7, < 6.11.5 | 6.11.5 |
| Linux kernel | = 6.12-rc1 | No fix listed |
| Linux kernel | = 6.12-rc2 | No fix listed |
| Linux kernel | = 6.12-rc3 | No fix listed |
References
- MSRC Security Update Guide vendor-advisory
- kernel vendor-advisory
- Debian Security Tracker CVE-2024-50082 vendor-advisory
- Ubuntu CVE tracker vendor-advisory
- USN-7276-1 vendor-advisory
- USN-7277-1 vendor-advisory
- USN-7288-1 vendor-advisory
- USN-7289-1 vendor-advisory
- USN-7291-1 vendor-advisory
- USN-7288-2 vendor-advisory
- USN-7289-2 vendor-advisory
- USN-7293-1 vendor-advisory
- USN-7294-1 vendor-advisory
- USN-7295-1 vendor-advisory
- USN-7289-3 vendor-advisory
- USN-7305-1 vendor-advisory
- USN-7289-4 vendor-advisory
- USN-7308-1 vendor-advisory
- USN-7294-2 vendor-advisory
- USN-7294-3 vendor-advisory
- USN-7310-1 vendor-advisory
- USN-7294-4 vendor-advisory
- USN-7331-1 vendor-advisory
- USN-7383-1 vendor-advisory
- USN-7384-1 vendor-advisory
- USN-7385-1 vendor-advisory
- USN-7386-1 vendor-advisory
- USN-7383-2 vendor-advisory
- USN-7388-1 vendor-advisory
- USN-7389-1 vendor-advisory
- USN-7390-1 vendor-advisory
- USN-7393-1 vendor-advisory
- USN-7384-2 vendor-advisory
- USN-7401-1 vendor-advisory
- USN-7403-1 vendor-advisory
- USN-7413-1 vendor-advisory
- USN-7451-1 vendor-advisory
- USN-7458-1 vendor-advisory
- USN-7468-1 vendor-advisory
- USN-7523-1 vendor-advisory
- USN-7524-1 vendor-advisory
- USN-7539-1 vendor-advisory
- USN-7540-1 vendor-advisory
- www.cve.org
- git.kernel.org
- git.kernel.org patch
- git.kernel.org patch
- git.kernel.org patch
- git.kernel.org patch
- git.kernel.org patch
- git.kernel.org patch
- lists.debian.org
- lists.debian.org
- ENISA EUVD EUVD-2024-44719 third-party-advisory