Skip to content

CVE-2026-98302 net: fddi: skfp: fix NULL deref when setting the MAC address while down

MediumCVSS 6.7 EPSS 0.18%
Published
Updated
Exploit status
No public exploit known
Technology
Linux KernelUbuntuDebianRed Hat

Description

In the Linux kernel, the following vulnerability has been resolved:

net: fddi: skfp: fix NULL deref when setting the MAC address while down

skfp_ctl_set_mac_address() calls ResetAdapter() unconditionally, without
checking netif_running(). ResetAdapter() first calls card_stop(), which
sets smc->hw.hw_state to STOPPED, and then mac_drv_clear_tx_queue(),
which walks the two transmit queues:

for (i = QUEUE_S; i <= QUEUE_A0; i++) {
	queue = smc->hw.fp.tx[i] ;
	...
	t = queue->tx_curr_get ;

smc->hw.fp.tx[] is only populated by init_tx(), which is reached from
skfp_open() through init_smt() -> init_fddi_driver() -> init_fplus() ->
init_mac() -> init_tx(). The private area is allocated and zeroed by
alloc_fddidev(), so on an interface that has never been brought up both
queue pointers are still NULL. The hw_state test at the top of
mac_drv_clear_tx_queue() does not catch this, because card_stop() has
just set STOPPED; the function proceeds into the loop and dereferences
NULL. ResetAdapter() does call init_smt() itself, but only after the
queues have been cleared.

Setting the MAC address on a down interface therefore oopses:

ip link set dev fddi0 address 02:00:00:00:00:01

BUG: KASAN: null-ptr-deref in mac_drv_clear_tx_queue+0x68/0x2c0 [skfp]
Read of size 8 at addr 0000000000000010 by task ip/302
Call Trace:
<TASK>
mac_drv_clear_tx_queue+0x68/0x2c0 [skfp 6c01d4bab63c36978bd0a7d7e90837adb44cc37b]
ResetAdapter+0x29/0x100 [skfp 6c01d4bab63c36978bd0a7d7e90837adb44cc37b]
skfp_ctl_set_mac_address+0x57/0x80 [skfp 6c01d4bab63c36978bd0a7d7e90837adb44cc37b]
netif_set_mac_address+0x1e4/0x2c0
do_setlink+0x684/0x2680
</TASK>

Address 0x10 is the offset of tx_curr_get, the third pointer in
struct s_smt_tx_queue, on 64-bit. mac_drv_clear_rx_queue(), which
ResetAdapter() calls immediately afterwards, dereferences
smc->hw.fp.rx[QUEUE_R1] in the same way behind the same ineffective
hw_state test; the transmit queue merely crashes first. Both are
covered by the guard below.

Skip the adapter reset when the interface is down. dev_addr_set() is
left unconditional, so the new address is still recorded in
dev->dev_addr. Nothing is lost by not resetting the adapter here:
skfp_open() deliberately re-reads the factory address on every open,

read_address(smc, NULL);
eth_hw_addr_set(dev, smc->hw.fddi_canon_addr.a);

and the comment above it states this is done to discard exactly such an
address override across a close/open cycle. An address set while the
interface is down could not have survived the following open even
before this change, so the guard removes no working behaviour. Guarding
the hardware side of ndo_set_mac_address() with netif_running() is
established practice; skge_set_mac_address() has done so since commit
2eb3e621c4e0 ("skge: set mac address bonding fix").

Guarding the reset as a whole, rather than NULL-checking the queues, is
also what the rest of the driver expects. After a previous open/close
the queue pointers are stale but non-NULL, so there is no crash, yet
ResetAdapter() goes on to call smt_online() and STI_FBI() ("Enable
Board Interrupts") while skfp_close() has already called free_irq() -
the adapter would be brought back online with no handler installed. The
only other ResetAdapter() caller is skfp_interrupt(), which by
construction runs only while the device is open.

Found by automated driver testing against an emulated SysKonnect FDDI
adapter under a KASAN-enabled 7.0.0 kernel. Triggering it requires
CAP_NET_ADMIN.

Upgrade path

14 packages: 14 fixed.

PackageAffectedFixed inStatus
azure linux kernel(Azure Linux 3.0) < 6.6.158.1-1 6.6.158.1-1 Fixed
azure linux kernel(Azure Linux 4.0) < 0:6.18.57-1.1.azl4 0:6.18.57-1.1.azl4 Fixed
debian/linux(Debian 12) < 6.1.190-1; = 6.1.27-1; = 6.1.37-1; = 6.1.38-1 +54 more 6.1.190-1 Fixed
debian/linux(Debian 13) < 6.12.113-1; = 6.12.38-1; = 6.12.41-1; = 6.12.43-1 +33 more 6.12.113-1 Fixed
debian/linux(Debian 14) < 7.2.8-1; = 6.12.38-1; = 6.12.41-1; = 6.12.43-1 +179 more 7.2.8-1 Fixed
debian/linux-6.12(Debian 12) < 6.12.113-1~deb12u1; = 6.12.100-1~deb12u1; = 6.12.101-1~deb12u1; = 6.12.107-1~deb12u1 +1 more 6.12.113-1~deb12u1 Fixed
Linux kernel < 5.10.271; < 5.15.222; < 6.1.189; < 6.6.158 +13 more 5.10.271, 5.15.222, 5fd0f401b3eee95c93daa35ef99cb03d676031f0, 6.1.189, 6.6.158, 6.12.112, 6.18.54, 7.2.8, 7.3, 7c8810c2e69c3d9ca6df870b40ae9218e50b4fb1, 616ba18b2cfb72b7bea214bdd72df2485b2e37dc, 731db6110b3148331ed8d5d11a564bfd520721d9, 438131e7ae847e907d345bf504d7e25585561b5c, 822903ed991971780db1db1be31a4f00e2b13e30, 835903bea770ad96ab4322e18d98e00f8e0b39c3, d6f63fdb298d546a47790cb373db65462c264d04 Fixed
ubuntu/linux(Ubuntu 22.04) < 5.15.0-202.212 5.15.0-202.212 Fixed
ubuntu/linux(Ubuntu 24.04) < 6.8.0-149.149 6.8.0-149.149 Fixed
ubuntu/linux(Ubuntu 26.04) < 7.0.0-42.42 7.0.0-42.42 Fixed
ubuntu/linux-kvm(Ubuntu 22.04) < 5.15.0-1111.116 5.15.0-1111.116 Fixed
ubuntu/linux-raspi(Ubuntu 22.04) < 5.15.0-1113.116 5.15.0-1113.116 Fixed
ubuntu/linux-raspi(Ubuntu 24.04) < 6.8.0-1068.72 6.8.0-1068.72 Fixed
ubuntu/linux-raspi(Ubuntu 26.04) < 7.0.0-1023.23 7.0.0-1023.23 Fixed

Affected products

ProductAffected versionsFixed in
Linux kernel >= 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2, < 835903bea770ad96ab4322e18d98e00f8e0b39c3 835903bea770ad96ab4322e18d98e00f8e0b39c3
Linux kernel >= 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2, < 5fd0f401b3eee95c93daa35ef99cb03d676031f0 5fd0f401b3eee95c93daa35ef99cb03d676031f0
Linux kernel >= 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2, < 731db6110b3148331ed8d5d11a564bfd520721d9 731db6110b3148331ed8d5d11a564bfd520721d9
Linux kernel >= 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2, < 822903ed991971780db1db1be31a4f00e2b13e30 822903ed991971780db1db1be31a4f00e2b13e30
Linux kernel >= 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2, < 616ba18b2cfb72b7bea214bdd72df2485b2e37dc 616ba18b2cfb72b7bea214bdd72df2485b2e37dc
Linux kernel >= 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2, < d6f63fdb298d546a47790cb373db65462c264d04 d6f63fdb298d546a47790cb373db65462c264d04
Linux kernel >= 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2, < 438131e7ae847e907d345bf504d7e25585561b5c 438131e7ae847e907d345bf504d7e25585561b5c
Linux kernel >= 1da177e4c3f41524e886b7f1b8a0c1fc7321cac2, < 7c8810c2e69c3d9ca6df870b40ae9218e50b4fb1 7c8810c2e69c3d9ca6df870b40ae9218e50b4fb1
Linux kernel = 2.6.12 No fix listed
Linux kernel < 5.10.271 5.10.271
Linux kernel < 5.15.222 5.15.222
Linux kernel < 6.1.189 6.1.189
Linux kernel < 6.6.158 6.6.158
Linux kernel < 6.12.112 6.12.112
Linux kernel < 6.18.54 6.18.54
Linux kernel < 7.2.8 7.2.8
Linux kernel < 7.3 7.3
debian/linux(Debian:12) < 6.1.190-1 6.1.190-1
debian/linux(Debian:12) = 6.1.106-1 No fix listed
debian/linux(Debian:12) = 6.1.106-2 No fix listed
debian/linux(Debian:12) = 6.1.106-3 No fix listed
debian/linux(Debian:12) = 6.1.112-1 No fix listed
debian/linux(Debian:12) = 6.1.115-1 No fix listed
debian/linux(Debian:12) = 6.1.119-1 No fix listed
debian/linux(Debian:12) = 6.1.123-1 No fix listed
Show 175 more
ProductAffected versionsFixed in
debian/linux(Debian:12) = 6.1.124-1 No fix listed
debian/linux(Debian:12) = 6.1.128-1 No fix listed
debian/linux(Debian:12) = 6.1.129-1 No fix listed
debian/linux(Debian:12) = 6.1.133-1 No fix listed
debian/linux(Debian:12) = 6.1.135-1 No fix listed
debian/linux(Debian:12) = 6.1.137-1 No fix listed
debian/linux(Debian:12) = 6.1.139-1 No fix listed
debian/linux(Debian:12) = 6.1.140-1 No fix listed
debian/linux(Debian:12) = 6.1.147-1 No fix listed
debian/linux(Debian:12) = 6.1.148-1 No fix listed
debian/linux(Debian:12) = 6.1.153-1 No fix listed
debian/linux(Debian:12) = 6.1.158-1 No fix listed
debian/linux(Debian:12) = 6.1.159-1 No fix listed
debian/linux(Debian:12) = 6.1.162-1 No fix listed
debian/linux(Debian:12) = 6.1.164-1 No fix listed
debian/linux(Debian:12) = 6.1.170-1 No fix listed
debian/linux(Debian:12) = 6.1.170-2 No fix listed
debian/linux(Debian:12) = 6.1.170-3 No fix listed
debian/linux(Debian:12) = 6.1.172-1 No fix listed
debian/linux(Debian:12) = 6.1.174-1 No fix listed
debian/linux(Debian:12) = 6.1.176-1 No fix listed
debian/linux(Debian:12) = 6.1.177-1 No fix listed
debian/linux(Debian:12) = 6.1.180-1 No fix listed
debian/linux(Debian:12) = 6.1.187-1 No fix listed
debian/linux(Debian:12) = 6.1.27-1 No fix listed
debian/linux(Debian:12) = 6.1.37-1 No fix listed
debian/linux(Debian:12) = 6.1.38-1 No fix listed
debian/linux(Debian:12) = 6.1.38-2 No fix listed
debian/linux(Debian:12) = 6.1.38-2~bpo11+1 No fix listed
debian/linux(Debian:12) = 6.1.38-3 No fix listed
debian/linux(Debian:12) = 6.1.38-4 No fix listed
debian/linux(Debian:12) = 6.1.38-4~bpo11+1 No fix listed
debian/linux(Debian:12) = 6.1.52-1 No fix listed
debian/linux(Debian:12) = 6.1.55-1 No fix listed
debian/linux(Debian:12) = 6.1.55-1~bpo11+1 No fix listed
debian/linux(Debian:12) = 6.1.64-1 No fix listed
debian/linux(Debian:12) = 6.1.66-1 No fix listed
debian/linux(Debian:12) = 6.1.67-1 No fix listed
debian/linux(Debian:12) = 6.1.69-1 No fix listed
debian/linux(Debian:12) = 6.1.69-1~bpo11+1 No fix listed
debian/linux(Debian:12) = 6.1.76-1 No fix listed
debian/linux(Debian:12) = 6.1.76-1~bpo11+1 No fix listed
debian/linux(Debian:12) = 6.1.82-1 No fix listed
debian/linux(Debian:12) = 6.1.85-1 No fix listed
debian/linux(Debian:12) = 6.1.90-1 No fix listed
debian/linux(Debian:12) = 6.1.90-1~bpo11+1 No fix listed
debian/linux(Debian:12) = 6.1.94-1 No fix listed
debian/linux(Debian:12) = 6.1.94-1~bpo11+1 No fix listed
debian/linux(Debian:12) = 6.1.98-1 No fix listed
debian/linux(Debian:12) = 6.1.99-1 No fix listed
debian/linux(Debian:13) < 6.12.113-1 6.12.113-1
debian/linux(Debian:13) = 6.12.100-1 No fix listed
debian/linux(Debian:13) = 6.12.101-1 No fix listed
debian/linux(Debian:13) = 6.12.105-1 No fix listed
debian/linux(Debian:13) = 6.12.107-1 No fix listed
debian/linux(Debian:13) = 6.12.111-1 No fix listed
debian/linux(Debian:13) = 6.12.38-1 No fix listed
debian/linux(Debian:13) = 6.12.41-1 No fix listed
debian/linux(Debian:13) = 6.12.43-1 No fix listed
debian/linux(Debian:13) = 6.12.43-1~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.48-1 No fix listed
debian/linux(Debian:13) = 6.12.57-1 No fix listed
debian/linux(Debian:13) = 6.12.57-1~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.63-1 No fix listed
debian/linux(Debian:13) = 6.12.63-1~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.69-1 No fix listed
debian/linux(Debian:13) = 6.12.69-1~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.73-1 No fix listed
debian/linux(Debian:13) = 6.12.73-1~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.74-1 No fix listed
debian/linux(Debian:13) = 6.12.74-2 No fix listed
debian/linux(Debian:13) = 6.12.74-2~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.85-1 No fix listed
debian/linux(Debian:13) = 6.12.85-1~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.86-1 No fix listed
debian/linux(Debian:13) = 6.12.86-1~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.88-1 No fix listed
debian/linux(Debian:13) = 6.12.88-1~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.90-1 No fix listed
debian/linux(Debian:13) = 6.12.90-1~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.90-2 No fix listed
debian/linux(Debian:13) = 6.12.90-2~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.94-1 No fix listed
debian/linux(Debian:13) = 6.12.94-1~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.95-1 No fix listed
debian/linux(Debian:13) = 6.12.95-1~bpo12+1 No fix listed
debian/linux(Debian:13) = 6.12.96-1 No fix listed
debian/linux(Debian:14) < 7.2.8-1 7.2.8-1
debian/linux(Debian:14) = 6.12.100-1 No fix listed
debian/linux(Debian:14) = 6.12.101-1 No fix listed
debian/linux(Debian:14) = 6.12.105-1 No fix listed
debian/linux(Debian:14) = 6.12.107-1 No fix listed
debian/linux(Debian:14) = 6.12.111-1 No fix listed
debian/linux(Debian:14) = 6.12.113-1 No fix listed
debian/linux(Debian:14) = 6.12.38-1 No fix listed
debian/linux(Debian:14) = 6.12.41-1 No fix listed
debian/linux(Debian:14) = 6.12.43-1 No fix listed
debian/linux(Debian:14) = 6.12.43-1~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.48-1 No fix listed
debian/linux(Debian:14) = 6.12.57-1 No fix listed
debian/linux(Debian:14) = 6.12.57-1~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.63-1 No fix listed
debian/linux(Debian:14) = 6.12.63-1~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.69-1 No fix listed
debian/linux(Debian:14) = 6.12.69-1~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.73-1 No fix listed
debian/linux(Debian:14) = 6.12.73-1~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.74-1 No fix listed
debian/linux(Debian:14) = 6.12.74-2 No fix listed
debian/linux(Debian:14) = 6.12.74-2~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.85-1 No fix listed
debian/linux(Debian:14) = 6.12.85-1~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.86-1 No fix listed
debian/linux(Debian:14) = 6.12.86-1~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.88-1 No fix listed
debian/linux(Debian:14) = 6.12.88-1~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.90-1 No fix listed
debian/linux(Debian:14) = 6.12.90-1~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.90-2 No fix listed
debian/linux(Debian:14) = 6.12.90-2~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.94-1 No fix listed
debian/linux(Debian:14) = 6.12.94-1~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.95-1 No fix listed
debian/linux(Debian:14) = 6.12.95-1~bpo12+1 No fix listed
debian/linux(Debian:14) = 6.12.96-1 No fix listed
debian/linux(Debian:14) = 6.13.10-1~exp1 No fix listed
debian/linux(Debian:14) = 6.13.11-1~exp1 No fix listed
debian/linux(Debian:14) = 6.13.2-1~exp1 No fix listed
debian/linux(Debian:14) = 6.13.3-1~exp1 No fix listed
debian/linux(Debian:14) = 6.13.4-1~exp1 No fix listed
debian/linux(Debian:14) = 6.13.5-1~exp1 No fix listed
debian/linux(Debian:14) = 6.13.6-1~exp1 No fix listed
debian/linux(Debian:14) = 6.13.7-1~exp1 No fix listed
debian/linux(Debian:14) = 6.13.8-1~exp1 No fix listed
debian/linux(Debian:14) = 6.13.9-1~exp1 No fix listed
debian/linux(Debian:14) = 6.13~rc6-1~exp1 No fix listed
debian/linux(Debian:14) = 6.13~rc7-1~exp1 No fix listed
debian/linux(Debian:14) = 6.14.3-1~exp1 No fix listed
debian/linux(Debian:14) = 6.14.5-1~exp1 No fix listed
debian/linux(Debian:14) = 6.14.6-1~exp1 No fix listed
debian/linux(Debian:14) = 6.15-1~exp1 No fix listed
debian/linux(Debian:14) = 6.15.1-1~exp1 No fix listed
debian/linux(Debian:14) = 6.15.2-1~exp1 No fix listed
debian/linux(Debian:14) = 6.15.3-1~exp1 No fix listed
debian/linux(Debian:14) = 6.15.4-1~exp1 No fix listed
debian/linux(Debian:14) = 6.15.5-1~exp1 No fix listed
debian/linux(Debian:14) = 6.15.6-1~exp1 No fix listed
debian/linux(Debian:14) = 6.15~rc7-1~exp1 No fix listed
debian/linux(Debian:14) = 6.16-1~exp1 No fix listed
debian/linux(Debian:14) = 6.16.1-1~exp1 No fix listed
debian/linux(Debian:14) = 6.16.10-1 No fix listed
debian/linux(Debian:14) = 6.16.11-1 No fix listed
debian/linux(Debian:14) = 6.16.12-1 No fix listed
debian/linux(Debian:14) = 6.16.12-1~bpo13+1 No fix listed
debian/linux(Debian:14) = 6.16.12-2 No fix listed
debian/linux(Debian:14) = 6.16.3-1 No fix listed
debian/linux(Debian:14) = 6.16.3-1~bpo13+1 No fix listed
debian/linux(Debian:14) = 6.16.5-1 No fix listed
debian/linux(Debian:14) = 6.16.6-1 No fix listed
debian/linux(Debian:14) = 6.16.7-1 No fix listed
debian/linux(Debian:14) = 6.16.8-1 No fix listed
debian/linux(Debian:14) = 6.16.9-1 No fix listed
debian/linux(Debian:14) = 6.16~rc7-1~exp1 No fix listed
debian/linux(Debian:14) = 6.17.10-1 No fix listed
debian/linux(Debian:14) = 6.17.11-1 No fix listed
debian/linux(Debian:14) = 6.17.12-1 No fix listed
debian/linux(Debian:14) = 6.17.13-1 No fix listed
debian/linux(Debian:14) = 6.17.13-1~bpo13+1 No fix listed
debian/linux(Debian:14) = 6.17.2-1~exp1 No fix listed
debian/linux(Debian:14) = 6.17.5-1~exp1 No fix listed
debian/linux(Debian:14) = 6.17.6-1 No fix listed
debian/linux(Debian:14) = 6.17.7-1 No fix listed
debian/linux(Debian:14) = 6.17.7-2 No fix listed
debian/linux(Debian:14) = 6.17.8-1 No fix listed
debian/linux(Debian:14) = 6.17.8-1~bpo13+1 No fix listed

References