Skip to content

CVE-2026-99384 smb: client: fix OOB read of the resume name sent in TRANS2_FIND_NEXT2

Unknown
Published
Updated
Exploit status
No public exploit known

Description

In the Linux kernel, the following vulnerability has been resolved:

smb: client: fix OOB read of the resume name sent in TRANS2_FIND_NEXT2

cifs_fill_dirent() reads the fixed part of a directory entry and the
name length it holds, or for SMB_FIND_FILE_UNIX scans the name for its
terminating NUL, without knowing where the response ends.
cifs_save_resume_key() calls it for the entry at the LastNameOffset the
server chose, after every FindNext and after the FindFirst of a search
rewind, and records the name it returns as the resume name of the
search without bounding it; the next CIFSFindNext() copies up to
PATH_MAX - 1 bytes from that name into its request and sends them to
the server. cifs_filldir() bounds
the name against the end of the response since
commit f8cf09a53a0d ("smb: client: bound dirent name against end of
SMB response in cifs_filldir"), but only after cifs_fill_dirent() has
read the entry, and nxt_dir_entry() checks the entries it walks only
against sizeof(FILE_DIRECTORY_INFO), for every level but
SMB_FIND_FILE_INFO_STANDARD, and never sees the first entry of a
response.

Bounding where last_entry starts, as the preceding patch does, does
not bound the read. A last entry that starts within the final bytes of
the response still has its fixed part read past the end of the
received data, and the name length it declares, a __le32 for every
level but SMB_FIND_FILE_INFO_STANDARD and SMB_FIND_FILE_UNIX, is
recorded without being checked against anything. CIFSFindNext()
rejects only a length of PATH_MAX or more, then copies the name, up to
4095 bytes, into its request and sends it, and as the report below
shows that copy can run past the end of the cifs_request allocation
that holds the response. For SMB_FIND_FILE_UNIX the name is in
addition scanned for its terminating NUL over up to PATH_MAX + 1
UTF-16 units, or PATH_MAX bytes, before any check. The FindNext that
carries the name is only sent by the SMB1 dialect, which is not
negotiated by default; reaching it requires an explicit vers=1.0
mount.

With KASAN enabled, a response whose last entry declares a name
longer than the bytes that follow it gives:

==================================================================
BUG: KASAN: slab-out-of-bounds in CIFSFindNext+0x8ca/0x14c0
Read of size 4080 at addr ffff88807c823f98 by task ls/83

CPU: 0 UID: 0 PID: 83 Comm: ls Not tainted 7.3.0-rc4-00457-gf14572c203d5 #69 PREEMPT(lazy)
Call Trace:
<TASK>
kasan_report+0xdf/0x1a0
kasan_check_range+0x10f/0x1e0
__asan_memcpy+0x23/0x60
CIFSFindNext+0x8ca/0x14c0
cifs_readdir+0xf51/0x29c0
iterate_dir+0x1c0/0x570
__x64_sys_getdents64+0x133/0x270
do_syscall_64+0x109/0x5d0
entry_SYSCALL_64_after_hwframe+0x77/0x7f
</TASK>

Allocated by task 83 on cpu 1 at 13.497119s:
cifs_buf_get+0x36/0x90
smb_init+0x4f/0x110
CIFSFindNext+0xf7/0x14c0
cifs_readdir+0xf51/0x29c0

The buggy address belongs to the object at ffff88807c820000
which belongs to the cache cifs_request of size 16588
The buggy address is located 16280 bytes inside of
allocated 16588-byte region [ffff88807c820000, ffff88807c8240cc)

The read is the memcpy() that copies the recorded name into the next
request, so those bytes go to the server.

Pass the end of the response to cifs_fill_dirent() and have it reject
an entry whose fixed part does not fit or whose name extends past the
end, before either is used, so that both callers are covered;
cifs_save_resume_key() computes the end the same way cifs_readdir()
does. The name bound compares the bytes left between the name and the
end with the name length rather than adding the length to the name
pointer, since the length is a 32-bit value taken from the entry and
the sum could wrap on 32-bit systems. cifs_fill_dirent() is also used
on the SMB2 readdir path; there smb2_parse_query_directory() has
already checked every entry against the end of the response, so a
vali
---truncated---

Affected products

ProductAffected versionsFixed in
Linux kernel >= 0752f1522a9120f731232919f7ad904e9e22b8ce, < 0cc7589ab18a891eb9aa8621f76e1eb09a6d0704 0cc7589ab18a891eb9aa8621f76e1eb09a6d0704
Linux kernel >= 0752f1522a9120f731232919f7ad904e9e22b8ce, < 556c3a72f58e0ce4356d57301712cbcd7b2e4c65 556c3a72f58e0ce4356d57301712cbcd7b2e4c65
Linux kernel >= 0752f1522a9120f731232919f7ad904e9e22b8ce, < 7141cde58f9dc15cf0869529ba2cb09fb0f082e5 7141cde58f9dc15cf0869529ba2cb09fb0f082e5
Linux kernel >= 0752f1522a9120f731232919f7ad904e9e22b8ce, < f8171804a39ee89a11cd462f67862899de9c6b10 f8171804a39ee89a11cd462f67862899de9c6b10
Linux kernel = bc15485e6a3cd20829cfa58bc9111e0bfc9cf303 No fix listed
Linux kernel = 282333bd7f759cdd9362e793b85db08780516416 No fix listed
Linux kernel = 92fa67e9260a65f69d868c4fcc92c9cee428c6f9 No fix listed
Linux kernel >= 2.6.25.19, < 2.6.26 2.6.26
Linux kernel >= 2.6.26.7, < 2.6.27 2.6.27
Linux kernel >= 2.6.27.2, < 2.6.28 2.6.28
Linux kernel = 2.6.28 No fix listed
Linux kernel < 6.12.118 6.12.118
Linux kernel < 6.18.64 6.18.64
Linux kernel < 7.3.2 7.3.2
Linux kernel < 7.4-rc1 7.4-rc1

References